NOTICE: This version of the NSF Unidata web site (archive.unidata.ucar.edu) is no longer being updated.
Current content can be found at unidata.ucar.edu.

To learn about what's going on, see About the Archive Site.

[netcdf-hdf] build errors in svn

NOTE: The netcdf-hdf mailing list is no longer active. The list archives are made available for historical reasons.

Hi.  Why are there two netcdf_par.h files?

The library has ./include/netcdf_par.h and ./libsrc/netcdf_par.h .
Further, those two files differ.  The libsrc version contains
mis-matched preprocessor directives such that --enable-parallel does
not compile.

Patch attached, but I would really like to see one of those versions
deleted so that this class of problem doesn't happen in the future.


>From bc4112b1867d65c18b8aee3ecd7245df0ca80ca0 Mon Sep 17 00:00:00 2001
From: Rob Latham <robl@xxxxxxxxxxx>
Date: Tue, 26 Jun 2012 09:12:59 -0500
Subject: [PATCH] mismatched preprocessor directives

when --enable-parallel selected, the library uses the netcdf_par in
libsrc, which contains this obvious syntax error.  Why are there two
netcdf_par.h files?
---
 libsrc/netcdf_par.h |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/libsrc/netcdf_par.h b/libsrc/netcdf_par.h
index a5e77fb..d8216a5 100644
--- a/libsrc/netcdf_par.h
+++ b/libsrc/netcdf_par.h
@@ -11,6 +11,7 @@
 #define NETCDF_PAR_H 1
 
 #include <mpi.h>
+#include <netcdf.h>
 
 /* Keep C++ compilers from getting confused */
 #if defined(__cplusplus)
@@ -45,5 +46,6 @@ nc_open_par_fortran(const char *path, int mode, int comm,
 
 #if defined(__cplusplus)
 }
+#endif
 
 #endif /* NETCDF_PAR_H */
-- 
1.7.9.5



-- 
Rob Latham
Mathematics and Computer Science Division
Argonne National Lab, IL USA



  • 2012 messages navigation, sorted by:
    1. Thread
    2. Subject
    3. Author
    4. Date
    5. ↑ Table Of Contents
  • Search the netcdf-hdf archives: