Re: ForecastModelRun aggregation with explicit files

• To: "Godin, Michael" <Godin@xxxxxxxxx>
• Subject: Re: ForecastModelRun aggregation with explicit files
• From: John Caron <caron@xxxxxxxxxxxxxxxx>
• Date: Thu, 16 Mar 2006 12:37:28 -0700

Hi Michael:

The forecast model aggregation is still experimental, so im not surprised you 
see these problems.
Thanks you for the patch, I will incorporate it ASAP.

Godin, Michael wrote:

There appears to be an omission in the code for handling "forecastModelRun" aggregations when the files being aggregated are explicit files (specified with a "netcdf" element) as opposed to the contents of scanned directories (specified with a "scan" element). Esentially, the function checkOK is not being called for the explicit files.

A minor modification to the Aggregation#finish method appears to resolve the issue:

starting at line 338 or 339:
    //nestedDatasets.addAll(explicitDatasets);
    for (int i = 0; i < explicitDatasets.size(); i++) {
        Dataset dataset = (Dataset) explicitDatasets.get(i);
        if (dataset.checkOK(cancelTask))
                nestedDatasets.add(dataset);
    }

A workaround is to use <scan> elements instead of <netcdf> elements for explicit file, specifying the parent path in the "location" attribute and the file name in the "suffix" attribute, but this is a little hokey.

Regards, Mike

• References:
  • ForecastModelRun aggregation with explicit files
    • From: Godin, Michael