Re: [netcdf-java] typo causing bug in ucar.nc2.dataset.transform.UTM

• To: netcdf-java@xxxxxxxxxxxxxxxx
• Subject: Re: [netcdf-java] typo causing bug in ucar.nc2.dataset.transform.UTM
• From: John Caron <caron@xxxxxxxxxxxxxxxx>
• Date: Mon, 20 Jun 2011 12:33:53 -0600

thanks tommy, that fix will be in next release!

On 6/20/2011 12:11 PM, Tommy Jasmin wrote:

John -

Not sure if Variable.findAttribute does a trim() or not on incoming attribute names, but if not, the extra space in "inverse_flattening " is definitely a bug that should be fixed. Even if benign, it should probably be changed. Full class included below so

you can see what I mean - it's a very short file...


/*

* Copyright 1998-2009 University Corporation for Atmospheric Research/Unidata

 *
 * Portions of this software were developed by the Unidata Program at the
 * University Corporation for Atmospheric Research.
 *
 * Access and use of this software shall impose the following obligations
 * and understandings on the user. The user is granted the right, without
 * any fee or cost, to use, copy, modify, alter, enhance and distribute
 * this software, and any derivative works thereof, and its supporting
 * documentation for any purpose whatsoever, provided that this entire
 * notice appears in all copies of the software, derivative works and
 * supporting documentation.  Further, UCAR requests that the user credit
 * UCAR/Unidata in any publications that result from the use of this
 * software or in any product that includes this software. The names UCAR

* and/or Unidata, however, may not be used in any advertising or publicity * to endorse or promote any products or commercial entity unless specific

 * written permission is obtained from UCAR/Unidata. The user also

* understands that UCAR/Unidata is not obligated to provide the user with * any support, consulting, training or assistance of any kind with regard

 * to the use, operation and performance of this software nor to provide
 * the user with any updates, revisions, new versions or "bug fixes."
 *
 * THIS SOFTWARE IS PROVIDED BY UCAR/UNIDATA "AS IS" AND ANY EXPRESS OR
 * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
 * DISCLAIMED. IN NO EVENT SHALL UCAR/UNIDATA BE LIABLE FOR ANY SPECIAL,
 * INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING
 * FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
 * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION
 * WITH THE ACCESS, USE OR PERFORMANCE OF THIS SOFTWARE.
 */

package ucar.nc2.dataset.transform;

import ucar.nc2.dataset.CoordinateTransform;
import ucar.nc2.dataset.ProjectionCT;
import ucar.nc2.dataset.TransformType;
import ucar.nc2.dataset.NetcdfDataset;
import ucar.nc2.Variable;
import ucar.nc2.Attribute;
import ucar.unidata.geoloc.projection.UtmProjection;

/**

* Create a UTM Projection from the information in the Coordinate Transform Variable.

 *  *
 * @author caron
 */
public class UTM extends AbstractCoordTransBuilder {

  public String getTransformName() {
    return "UTM";
  }

  public TransformType getTransformType() {
    return TransformType.Projection;
  }

public CoordinateTransform makeCoordinateTransform(NetcdfDataset ds, Variable ctv) { int zone = (int) readAttributeDouble( ctv, "utm_zone_number", Double.NaN);

    boolean isNorth = zone > 0;
    zone = Math.abs(zone);

    Attribute a;
    double axis = 0.0, f = 0.0;
    if (null != (a = ctv.findAttribute( "semimajor_axis")))
      axis = a.getNumericValue().doubleValue();
    if (null != (a = ctv.findAttribute( "inverse_flattening ")))
      f = a.getNumericValue().doubleValue();

    // double a, double f, int zone, boolean isNorth

UtmProjection proj = (axis != 0.0) ? new UtmProjection(axis, f, zone, isNorth) : new UtmProjection(zone, isNorth);

    return new ProjectionCT(ctv.getShortName(), "FGDC", proj);
  }
}

• References:
  • [netcdf-java] typo causing bug in ucar.nc2.dataset.transform.UTM
    • From: Tommy Jasmin