Re: [netcdf-java] Bug in GRIB2 earth shape parsing

• To: Daniele Romagnoli <daniele.romagnoli@xxxxxxxxxxxxxxxx>
• Subject: Re: [netcdf-java] Bug in GRIB2 earth shape parsing
• From: Ryan May <rmay@xxxxxxxx>
• Date: Mon, 11 May 2015 16:19:28 -0600

Daniele,

Thanks for the report. We can discuss further over there.

Ryan

On Mon, May 11, 2015 at 7:46 AM, Daniele Romagnoli <
daniele.romagnoli@xxxxxxxxxxxxxxxx> wrote:

> Hi list,
> I think I have found a bug in earth shape parsing on Grib2gds class.
> Please, take a look to this issue:
> https://github.com/Unidata/thredds/issues/133
>
> It seems to me that for case 7 (earth radius specified by the user in
> meters) the code is checking in advance whether the provided value is in
> meters (instead of km).
> This results into a wrong *1000 default multiplication which causes
> returning an earth radius of 6.3...*10^9 meters instead of 6.3...*10^6
>
> I can create a pull request if needed.
> Cheers,
> Daniele
>
> --
> ==
> GeoServer Professional Services from the experts! Visit
> http://goo.gl/NWWaa2 for more information.
> ==
>
> Ing. Daniele Romagnoli
> Senior Software Engineer
>
> GeoSolutions S.A.S.
> Via Poggio alle Viti 1187
> 55054  Massarosa (LU)
> Italy
> phone: +39 0584 962313
> fax:      +39 0584 1660272
>
> http://www.geo-solutions.it
> http://twitter.com/geosolutions_it
>
> -------------------------------------------------------
>
> *AVVERTENZE AI SENSI DEL D.Lgs. 196/2003*
>
> Le informazioni contenute in questo messaggio di posta elettronica e/o
> nel/i file/s allegato/i sono da considerarsi strettamente riservate. Il
> loro utilizzo è consentito esclusivamente al destinatario del messaggio,
> per le finalità indicate nel messaggio stesso. Qualora riceviate questo
> messaggio senza esserne il destinatario, Vi preghiamo cortesemente di
> darcene notizia via e-mail e di procedere alla distruzione del messaggio
> stesso, cancellandolo dal Vostro sistema. Conservare il messaggio stesso,
> divulgarlo anche in parte, distribuirlo ad altri soggetti, copiarlo, od
> utilizzarlo per finalità diverse, costituisce comportamento contrario ai
> principi dettati dal D.Lgs. 196/2003.
>
>
>
> The information in this message and/or attachments, is intended solely for
> the attention and use of the named addressee(s) and may be confidential or
> proprietary in nature or covered by the provisions of privacy act
> (Legislative Decree June, 30 2003, no.196 - Italy's New Data Protection
> Code).Any use not in accord with its purpose, any disclosure, reproduction,
> copying, distribution, or either dissemination, either whole or partial, is
> strictly forbidden except previous formal approval of the named
> addressee(s). If you are not the intended recipient, please contact
> immediately the sender by telephone, fax or e-mail and delete the
> information in this message that has been received in error. The sender
> does not give any warranty or accept liability as the content, accuracy or
> completeness of sent messages and accepts no responsibility  for changes
> made after they were sent or for other risks which arise as a result of
> e-mail transmission, viruses, etc.
>
>
> _______________________________________________
> netcdf-java mailing list
> netcdf-java@xxxxxxxxxxxxxxxx
> For list information or to unsubscribe, visit:
> http://www.unidata.ucar.edu/mailing_lists/
>



-- 
Ryan May
Software Engineer
UCAR/Unidata
Boulder, CO

• References:
  • [netcdf-java] Bug in GRIB2 earth shape parsing
    • From: Daniele Romagnoli