NOTICE: This version of the NSF Unidata web site (archive.unidata.ucar.edu) is no longer being updated.
Current content can be found at unidata.ucar.edu.

To learn about what's going on, see About the Archive Site.


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[UDUNITS #SLV-499270]: udunits-2.1.24/lib/xml.c:1576: possible bad if test ?



David,

Good catch! Thanks.

> Hello there,
> 
> I just compiled udunits-2.1.24 with extra Linux gcc flag -Wlogical-op
> 
> It said
> 
> xml.c:1576:5: warning: logical 'or' of collectively exhaustive tests is 
> always true [-Wlogical-op]
> 
> Source code is
> 
>     if (currFile->context != UNIT_NAME || currFile->context != ALIAS_NAME) {
> 
> Suggest swap || for &&
> 
> Regards
> 
> David Binderman


Regards,
Steve Emmerson

Ticket Details
===================
Ticket ID: SLV-499270
Department: Support UDUNITS
Priority: Normal
Status: Closed